On Wednesday 17 June 2009 22:25:48 Marco Martin wrote: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/853/ > ----------------------------------------------------------- > > (Updated 2009-06-17 13:25:48.792781) > > > Review request for Plasma. > > > Summary > ------- > > the ocs dataengine works in this way, when asking for a list of people like > friends or nearby, it adds a new source for each person (and the applet > reacts on sourceadded connecting to each new source) this is nice because > the person source is quite clean and always with the same structure, but it > has the following problem: when a new person source arrives it's not > possible to know who asked for this, so for instance if the opendesktop > applet and the knowledgebase applet are loaded in the same time, when a > query in the knowledgebase is performed it will use the person dataengine > to fetch the avatars of the people who asked the questions, but this causes > all those people to be added in the friend list of the opendesktop applet > O.o because the opendesktop applet has no way to understand that those > people arrive from another kind of query > > soo, this patch puts all the people into the Data of the query source, > we'll have stuff like: Friends-foo that will contain Person-bar with all > the data, Person-baz and so forth. > > same treatment to KnowledgeBase > > forgotten to say, it a really biig change to do right now, but i think the > current behaviour has some potential problems that could be a bit nasty in > the future
Agreed, it warrants changing at this time since it's some sort of public interface that shouldn't change in a backwards-incompatible way once released. I've reviewed that patch and tested it, there don't seem to be regressions. Marco already committed it. Thanks, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
