On Wednesday 06 May 2009, Rob Scheepmaker wrote: > On Wednesday 06 May 2009 10:35:32 Aaron J. Seigo wrote: > > * when an extender has groups, attachedItems() will return those groups > > as items. in turn, that makes the "don't show the popup if we have > > nothing in it" test in PopupAppletPrivate::internalTogglePopup fail > > because there's always something there, even though the groups are no > > visible. i think we either need to keep groups out of attachedItems() > > (what would that break if anything?) or else have a "bool isEmpty() > > const" method that takes into consideration things like empty groups. > > I also do some is empty checks in Extender, and I had added a private > isEmpty function to Extender that does just that. PopupApplet is already > homies with Extender IIRC, so that function can be used there.
no, they aren't friends. i instead made isEmpty() part of the public API of extender. seems like the sort of things that's generally useful. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
