----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/671/#review1050 -----------------------------------------------------------
/trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp <http://reviewboard.kde.org/r/671/#comment703> waking every second isn't good; it should only start the timer when there are jobs, and even then 1s seems pretty agressive; probably once a minute would be plenty? /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp <http://reviewboard.kde.org/r/671/#comment702> this should be: Plasma::Applet::timerEvent(event); return; /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp <http://reviewboard.kde.org/r/671/#comment704> together with the "start when we have jobs" the timer should be killed at this point and start again when a new job appears. - Aaron On 2009-05-04 08:33:11, Rob Scheepmaker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/671/ > ----------------------------------------------------------- > > (Updated 2009-05-04 08:33:11) > > > Review request for Plasma. > > > Summary > ------- > > As an experiment, I'd tried this possible approach to the issue that (< wow, > review board is * too * smart :p) we probably want the completed jobs to get > automatically destroyed, as discussed in the Systray Jobs mailing list > discussion. The current timeout time is a bit arbitrary (5 minutes), but > works pretty well imo. The nice thing here is we don't start the timeout > until the computer is actually being used, so if you go away from your > computer to make some nice delicious meal (hmm, maybe a nice curry?), and a > job completes in the meantime, it will still show after you get back behind > your computer. > I think this behavior is quite nice, but let me know what you think, and if > you think we should use a different timeout time. But be quick, feature > freeze is today :p > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/CMakeLists.txt > 963164 > /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/config.h.in > PRE-CREATION > /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.h 963164 > /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp 963165 > > Diff: http://reviewboard.kde.org/r/671/diff > > > Testing > ------- > > > Thanks, > > Rob > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
