----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/652/#review1042 -----------------------------------------------------------
Ship it! looks like it just makes it possible to use as non-modal? looks good :) - Aaron On 2009-05-01 19:49:41, Chani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/652/ > ----------------------------------------------------------- > > (Updated 2009-05-01 19:49:41) > > > Review request for kdelibs and Plasma. > > > Summary > ------- > > kshortcutsdialog was designed to be modal and only modal. that doesn't work > very well for plasma. :) I added the possibility to use it non-modally. I > need this to finish off http://reviewboard.kde.org/r/639/ > > > Diffs > ----- > > /trunk/KDE/kdelibs/kdeui/dialogs/kshortcutsdialog.h 961912 > /trunk/KDE/kdelibs/kdeui/dialogs/kshortcutsdialog.cpp 961912 > > Diff: http://reviewboard.kde.org/r/652/diff > > > Testing > ------- > > modal and non-modal modes work with the plasma settings dialog > > > Thanks, > > Chani > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
