----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/637/ -----------------------------------------------------------
Review request for Plasma. Summary ------- this is just the code to read shortcuts from the rc file. it works, but I'm not 100% happy with it - that function added to Applet feels awkward and its name sucks, and I can't help wondering if maybe I should put it somewhere else, or duplicate it in containment so that it can be private... any thoughts? Diffs ----- /trunk/KDE/kdelibs/plasma/applet.h 960161 /trunk/KDE/kdelibs/plasma/applet.cpp 960161 /trunk/KDE/kdelibs/plasma/containment.cpp 960161 /trunk/KDE/kdelibs/plasma/corona.cpp 960161 Diff: http://reviewboard.kde.org/r/637/diff Testing ------- Thanks, Chani _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel