> On 2009-04-12 05:29:41, Aaron Seigo wrote: > > trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp, line 141 > > <http://reviewboard.kde.org/r/567/diff/2/?file=5189#file5189line141> > > > > why is this needed?
Because without this line, the widget does not have a transparent background. > On 2009-04-12 05:29:41, Aaron Seigo wrote: > > trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp, line 700 > > <http://reviewboard.kde.org/r/567/diff/2/?file=5189#file5189line700> > > > > zero preferred size? yes. Otherwise there is a problem resize buttons. > On 2009-04-12 05:29:41, Aaron Seigo wrote: > > trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp, line 778 > > <http://reviewboard.kde.org/r/567/diff/2/?file=5189#file5189line778> > > > > a feudal era french tax? an oversight! It's the french translation of "size"... :) > On 2009-04-12 05:29:41, Aaron Seigo wrote: > > trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp, line 97 > > <http://reviewboard.kde.org/r/567/diff/2/?file=5189#file5189line97> > > > > if (font().bold()) ? I wanted to do this at first. But you can try ... it does not work. And I do not know why. my only solution for the moment is: if (fontWeight() == 75) - Madlyn ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/567/#review902 ----------------------------------------------------------- On 2009-04-12 04:35:57, Madlyn MERCK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/567/ > ----------------------------------------------------------- > > (Updated 2009-04-12 04:35:57) > > > Review request for Plasma. > > > Summary > ------- > > This patch offers the possibility to format the text of the note. > It's a solution of the bug 171795 > (https://bugs.kde.org/show_bug.cgi?id=171795). > You can make your text bold, italic, strike-through... You can show format > options with the button '+' or with the text's popupmenu. > > If you notice any problem with this new option just tell me. > > > This addresses bug 171795. > https://bugs.kde.org/show_bug.cgi?id=171795 > > > Diffs > ----- > > trunk/KDE/kdeplasma-addons/applets/notes/notes.h 951942 > trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 951942 > > Diff: http://reviewboard.kde.org/r/567/diff > > > Testing > ------- > > > Screenshots > ----------- > > Screenshot1 > http://reviewboard.kde.org/r/567/s/104/ > Screenshot2 > http://reviewboard.kde.org/r/567/s/105/ > Screenshot3 > http://reviewboard.kde.org/r/567/s/106/ > > > Thanks, > > Madlyn > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
