-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/581/#review913
-----------------------------------------------------------


How to resize the spacer? :)

- Alessandro


On 2009-04-13 12:22:46, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/581/
> -----------------------------------------------------------
> 
> (Updated 2009-04-13 12:22:46)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> a thing requested several times and tried to implement several times: an 
> empty space for panels: doing it as a normal applet seems overkill and you 
> can add it on the desktop (ouch)
> this does indeed use an applet (tought about using a simple qgraphicswidget 
> but restoring the config becomes quite more complicate..) but it's private, 
> it's not in the list of applets and the view "knows" the applet, thing that 
> is ugly ugly, but is necessary in order to make impossible to drag it out of 
> the panel
> it's an expanding element and doesn't have config ui at all (and reeeally 
> shouldn't, would be cool to make it possible to be also a configurable fixed 
> ui, but no idea how to make it  not an ui mess)
> 
> things that probably will change:
> the add space action perhaps will become one of the standard panel add space 
> actions
> plasma linking to the applet... uuuugly, drag out of panel avoid perhaps 
> could be made using just the applet name, where is necessary is that now the 
> applet knows when the panel controller is open and it paints instead of being 
> invisible, this is quite nice but the implementation is really evil...
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/CMakeLists.txt 951847 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelappletoverlay.cpp 
> 951847 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.h 951847 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.cpp 
> 951847 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelspacer.h 
> PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelspacer.cpp 
> PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.cpp 951847 
>   
> /trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasma-applet-panelspacer-internal.desktop
>  PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/581/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to