----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/480/#review860 -----------------------------------------------------------
Ship it! looks good; have you also done the simple applet part of the patch? - Aaron On 2009-04-07 07:44:37, Arthur Mello wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/480/ > ----------------------------------------------------------- > > (Updated 2009-04-07 07:44:37) > > > Review request for Plasma. > > > Summary > ------- > > On kickoff (simpleapplet view) when a row is inserted on a used model its > position will be calculated based on other entries from same model. If no > such entry is found the new one will be appended on menu. As a new user, the > RecentlyUsed model will not have any rows when it is added to kickoff, so any > app used from there will be placed at the bottom of the menu. > > This patch add a not visible QAction to work as a model header on menu. If no > other entry from the same model is found we use > this header to put the new action on the right place. > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp > 950656 > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/favoritesmodel.h > 950656 > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/favoritesmodel.cpp > 950656 > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/leavemodel.h > 950656 > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/leavemodel.cpp > 950656 > > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/recentlyusedmodel.h > 950656 > > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/recentlyusedmodel.cpp > 950656 > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/systemmodel.h > 950656 > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/systemmodel.cpp > 950656 > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/menuview.h > 950656 > > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/menuview.cpp > 950656 > > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/simpleapplet.cpp > 950656 > > Diff: http://reviewboard.kde.org/r/480/diff > > > Testing > ------- > > > Thanks, > > Arthur > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
