----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/418/#review627 -----------------------------------------------------------
Ship it! looks good :) - Aaron On 2009-03-25 16:55:16, Jonathan Thomas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/418/ > ----------------------------------------------------------- > > (Updated 2009-03-25 16:55:16) > > > Review request for Plasma. > > > Summary > ------- > > This patch adds tooltip support to the icons in the Quicklaunch applet. > > This implements KDE wishlist item 180702: > https://bugs.kde.org/show_bug.cgi?id=180702 > > > This addresses bug 180702. > https://bugs.kde.org/show_bug.cgi?id=180702 > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp > 944579 > /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.h > 944579 > /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.cpp > 944579 > > Diff: http://reviewboard.kde.org/r/418/diff > > > Testing > ------- > > I've played around with it. Everything seems OK, (tooltips! shiny!) but I > haven't stress-tested it with broken .desktop files (ones that don't define > names) or anything like that. > > > Screenshots > ----------- > > Tooltip for konq > http://reviewboard.kde.org/r/418/s/75/ > > > Thanks, > > Jonathan > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel