> On 2009-03-24 10:53:27, Aaron Seigo wrote: > > we can certainly put an upper limit on the size of the images, and make > > them smaller on the sending side too. (better for the transmission over the > > bus) > > > > i think sticking with image_data makes sense; it's a place galago can and > > should be improved. > > > > other than a couple stray spaces in one of the method declarations in a > > header, this looks good ...
other than (and that's is the problem of the new systray implementation too), if all the extra params are removed from the struct, even the width and height the thing still works, because it sends png - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/405/#review588 ----------------------------------------------------------- On 2009-03-24 10:47:05, Rob Scheepmaker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/405/ > ----------------------------------------------------------- > > (Updated 2009-03-24 10:47:05) > > > Review request for Plasma. > > > Summary > ------- > > The oldschool Passive Popup notifications support custom images set through > KNotification::setPixmap. This isn't supported by the new plasma > notifications though. This patch makes knotify send the image over the dbus, > by using a QImage and saving the image to a png. This picture gets passed to > the notification dataengine through the hints map. > The way this is currently implemented is not entirely in line with the Galago > Spec. Galago specifies: > > "image_data" (iiibiiay) This is a raw data image format which describes > the width, height, rowstride, has alpha, bits per sample, channels and image > data respectively. We use this value if the icon field is left blank. > > This sounds a bit like overkill, plus we don't got compression this way. Not > only that, the Galago Spec specifies that image_data needs to be used here, > while in the chapter "icons", it's being called "icon_data". Talk about a > well engineered spec... So this left me wondering, since we already diverging > a bit from the galago spec, how compatible should we be with galago? > > Another 'problem' is that kopete contact images are quite big (96x96 i > guess), which makes notifications take up quite a lot more space. A smaller > maximum size might be appropriate. > > > Diffs > ----- > > /trunk/KDE/kdebase/runtime/knotify/notifybypopup.cpp 940258 > /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/core/notification.h > 943457 > > /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/core/notification.cpp > 943457 > > /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/notifications/dbusnotificationprotocol.cpp > 943457 > > /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/notificationwidget.h > 943457 > > /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/notificationwidget.cpp > 943457 > > /trunk/KDE/kdebase/workspace/plasma/dataengines/notifications/notificationsengine.cpp > 940258 > > Diff: http://reviewboard.kde.org/r/405/diff > > > Testing > ------- > > > Thanks, > > Rob > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
