----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/366/#review581 -----------------------------------------------------------
Definitely getting closer. After addressing the issues I've pointed out inline, you can commit (if you have an account, if you don't just send me the patch). Thanks trunk/KDE/kdeplasma-addons/applets/notes/config.ui <http://reviewboard.kde.org/r/366/#comment360> Background text color is not quite accurate, how about "Active Line Highlight Color"? trunk/KDE/kdeplasma-addons/applets/notes/notes.h <http://reviewboard.kde.org/r/366/#comment361> Truncate empty lines please, that makes future patches cleaner trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp <http://reviewboard.kde.org/r/366/#comment362> Please make config options consistently camelcase, in this case textBackgroundColor trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp <http://reviewboard.kde.org/r/366/#comment365> ... is called when you change the line you're editing trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp <http://reviewboard.kde.org/r/366/#comment366> truncate empty lines - Sebastian On 2009-03-23 07:15:43, Zareth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/366/ > ----------------------------------------------------------- > > (Updated 2009-03-23 07:15:43) > > > Review request for Plasma. > > > Summary > ------- > > This patch add to the plasmoid notes the possibility to choose a background > color > different from the general background of the Notes plasmoid for the line that > is currently edited. > > The idea came from a bug track concerning the bad view of the Notes when we > choose a black > background color because we can't see the cursor. This option is an > alternative to the problem. > > If you notice any problems with this new option just tell me > > > Diffs > ----- > > trunk/KDE/kdeplasma-addons/applets/notes/notes.h 943151 > trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 943151 > trunk/KDE/kdeplasma-addons/applets/notes/config.ui 943151 > > Diff: http://reviewboard.kde.org/r/366/diff > > > Testing > ------- > > > Screenshots > ----------- > > New option visual > http://reviewboard.kde.org/r/366/s/65/ > > > Thanks, > > Zareth > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
