----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/343/#review511 -----------------------------------------------------------
/trunk/KDE/kdelibs/plasma/svg.cpp <http://reviewboard.kde.org/r/343/#comment299> this check is incorrect; it should be checking for d->themed. that is set by the call to d->setImagePath, so the code should look something like: d->setImagePath(svgFilePath, this); if (!d->themed) { ... /trunk/KDE/kdelibs/plasma/theme.h <http://reviewboard.kde.org/r/343/#comment300> should have: @since 4.3 /trunk/KDE/kdelibs/plasma/theme.cpp <http://reviewboard.kde.org/r/343/#comment302> please add a comment that this should be merged with the other findInCache method above when we break BC: //BIC FIXME: .. /trunk/KDE/kdelibs/plasma/theme.cpp <http://reviewboard.kde.org/r/343/#comment301> code style: if (..) { yes, {} are required on single line ifs. - Aaron On 2009-03-16 07:03:26, Arthur Mello wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/343/ > ----------------------------------------------------------- > > (Updated 2009-03-16 07:03:26) > > > Review request for Plasma. > > > Summary > ------- > > Add support to check with file timestamp if cache for Plasma::Svg is still > valid. Today a entry on cache is discarded only if we have a Theme/Colour > change. This way if the svg file is changed a plasmoid will keep using the > old image. The file timest > amp is checked only on setImagePath to avoid a overhead every time a svg is > loaded. > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/svg.cpp 940045 > /trunk/KDE/kdelibs/plasma/theme.h 940045 > /trunk/KDE/kdelibs/plasma/theme.cpp 940045 > > Diff: http://reviewboard.kde.org/r/343/diff > > > Testing > ------- > > > Thanks, > > Arthur > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
