----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/293/#review470 -----------------------------------------------------------
Ship it! looks good; i dislike code that uses bools like this in methods, particularly constructors, but the API in kdelibs is done this way so it makes sense to match it. next might be to implement separators in kickoff.. in any case, this looks like it should go in right away :) p.s. good to see you again, Christian! - Aaron On 2009-03-13 14:24:25, Christian Loose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/293/ > ----------------------------------------------------------- > > (Updated 2009-03-13 14:24:25) > > > Review request for Plasma. > > > Summary > ------- > > This patch adds support for separators to the Kickoff applicationmodel and > the simpleapplet. It has no effect on the standard Kickoff menu and it makes > the classic menu style more KDE3 like. > > It's my first patch since at least one year, so be nice please. :-) > > > This addresses bug 187014. > https://bugs.kde.org/show_bug.cgi?id=187014 > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h > 939045 > > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp > 939045 > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/models.h 939045 > > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/menuview.cpp > 939045 > > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/simpleapplet.cpp > 939045 > > Diff: http://reviewboard.kde.org/r/293/diff > > > Testing > ------- > > Tested with latest svn trunk build. > Used plasmoidviewer to test launcher and simplelauncher. > > > Screenshots > ----------- > > menu with separator > http://reviewboard.kde.org/r/293/s/56/ > > > Thanks, > > Christian > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
