On Friday 13 March 2009, Jacopo De Simoi wrote: > as per communication in irc with aseigo, here is a patch (**against > 4.2 branch**) for better handling of stragglers in krunner. > Please note that the patch in libs is actually quite noisy because > there's also the backport of part of aseigo improvements for the > oldMatchesJob stuff. > the only relevant part is the "isRunning" method.
i think the method makes sense; instead of isRunning perhaps "bool
isCurrentlyActive() const"? (note that it should be a const method)
the implementation won't scale very nicely, but that's easily solved should
this become a performance bottleneck later with something more sophisticated
can be put in place (such as a per-runner job counter; easy enough :).
coding style:
if (job->runner() == runner) return true;
should be
if (job->runner() == runner) {
return true;
}
with those small changes, i think the kdelibs bit can go in.
the interface bit looks fairly harmless as well :)
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Software
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
