----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/63/#review339 -----------------------------------------------------------
the patch didn't make it, it seems. can you try to upload it again? in any case, i don't think we _really_ need an animation for when it isn't a popup and just shown full on the desktop, which would make the .5s timer unneccesary? - Aaron On 2009-02-28 08:23:30, Mohammad Mehdi Salem Naraghi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/63/ > ----------------------------------------------------------- > > (Updated 2009-02-28 08:23:30) > > > Review request for Plasma and Aaron Seigo. > > > Summary > ------- > > A little animation that mimics the behaviour of my sony erricsson handy > whenever I get to the main menu. The Icons in kickoff's tabbar are all placed > at the center of the tabbar before moving towards their intended location > when the menu is displayed. It's a hack as of now and doesn't even work when > the panel is placed on the right or left screen edge. But that's pretty easy > to fix if you guys like that behaviour. I am not sure, maybe the thing is > superfluous but hey, I like small useless animations. > > > Diffs > ----- > > KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.h 932966 > KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp 932966 > > Diff: http://reviewboard.kde.org/r/63/diff > > > Testing > ------- > > the animation doesn't work (yet) if the panel is placed on the right or left > screen edge. But adding support for that is pretty straightforward. > > > Thanks, > > Mohammad Mehdi > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
