----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/206/#review314 -----------------------------------------------------------
the screenshot looks pretty :) I wanna test it with a vertical panel, though... /trunk/KDE/kdelibs/plasma/dialog.cpp <http://reviewboard.kde.org/r/206/#comment180> why are you setting left and right to 0 in every case but default? - Chani On 2009-02-28 13:28:19, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/206/ > ----------------------------------------------------------- > > (Updated 2009-02-28 13:28:19) > > > Review request for Plasma. > > > Summary > ------- > > this makes all dialogs to not have the bottom border, not just the extender > based ones. > also vertical borders are deactivated, this solves also the fitts law problem > of kickoff > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/dialog.cpp 932222 > > Diff: http://reviewboard.kde.org/r/206/diff > > > Testing > ------- > > tested with panels at four edges, extenders handling is leaved as it was > (changed a bit the code to integrate with the other part, same algorithm) > > > Screenshots > ----------- > > > http://reviewboard.kde.org/r/206/s/43/ > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
