On Tuesday 17 February 2009, Fredrik Höglund wrote:

> > seems to work quite good, except for two things:
> > the tooltips seems to insist that they don't want to be transparent
> > the systemtray has garbage again with the raster graphicssystem (so i
> > didn't dream it up) i'm not sure if that's the case also with the old
> > method btw
>
> Reverting r907753 should fix the systray icons.
>
> You'll have to read my reply on kde-commits for the details, but the short
> version is that the move to using Qt::WA_TranslucentBackground combined
> with that patch means that Plasma is now explicitly telling Qt (and Gtk) to
> not use real transparency for the systray icons.

the strange thing is that i don't get junk with x11 graphics system,
while i get it for all icons with raster graphicssystem.
reverting that patch it fixes only qt4 icons but not qt3 and gtk ones

by the way, could make sense something like this?
forces 32 bits only when there are more than 16

Cheers,
Marco Martin
> Regards,
> Fredrik
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel


Index: protocols/fdo/fdoselectionmanager.cpp
===================================================================
--- protocols/fdo/fdoselectionmanager.cpp	(revision 927479)
+++ protocols/fdo/fdoselectionmanager.cpp	(working copy)
@@ -269,10 +269,10 @@
     XVisualInfo templ;
     templ.visualid = visual;
     XVisualInfo *xvi = XGetVisualInfo(d->display, VisualIDMask, &templ, &nvi);
-    if (xvi) {
+    if (xvi && xvi[0].depth > 16) {
         templ.screen  = xvi[0].screen;
-        templ.depth   = xvi[0].depth;
-        templ.c_class = xvi[0].c_class;
+        templ.depth   = 32;
+        templ.c_class = TrueColor;
         XFree(xvi);
         xvi = XGetVisualInfo(d->display, VisualScreenMask | VisualDepthMask | VisualClassMask,
                              &templ, &nvi);
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to