----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/92/ -----------------------------------------------------------
(Updated 2009-02-15 07:56:47.054930) Review request for Plasma. Changes ------- Forgot to add applethandle.cpp file... Summary ------- Instead of using hardcore numbers, it would be great to use the enums provided by KIconLoader whenever we use sizes for icons. Made the change for the obvious ones replacing "16" by KIconLoader::SizeSmall, "22" by KIconLoader::SizeSmallMedium and "32" by KIconLoader::SizeMedium. Diffs (updated) ----- /trunk/KDE/kdelibs/plasma/containment.cpp 926513 /trunk/KDE/kdelibs/plasma/extenderitem.cpp 926513 /trunk/KDE/kdelibs/plasma/private/applethandle.cpp 926513 /trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp 926513 /trunk/KDE/kdelibs/plasma/private/toolbox.cpp 926513 /trunk/KDE/kdelibs/plasma/widgets/signalplotter.cpp 926513 Diff: http://reviewboard.kde.org/r/92/diff Testing ------- Currently running in trunk Thanks, Artur _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel