Aaron J. Seigo wrote:
> On Wednesday 17 December 2008, Alain Boyer wrote:
>> I'm not sure that this is the best way to go about fixing the
>> onCurrentDesktop update.
> 
> unfortunately the patch is incorrrect. it makes every task emit "my desktop 
> has changed!" when that's not true at all. the task's desktop hasn't changed, 
> the currently active desktop has.
> 
>> This fixes the tasks data engine but
>> libtaskmanager is still broken...
> 
> in which way?

Currently, the taskmanager tasks do not broadcast when their 
onCurrentDesktop member changes. My attached patch fixed that.

I'm asking whether this change makes any sense at all? Although I may 
already have my answer.

>> Also, there is still a minor problem with some of the calls to
>> Task::refresh() being munged by d->lastUpdate in libs/taskmanager/task.cpp.
> 
> as i said on irc this morning, this was work in progress that i'm not 
> finished 
> with but will get back to today.

Alain.

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to