On Monday 15 December 2008, Ivan Čukić wrote: > On Monday, 15. December 2008. 3.39.07 Aaron J. Seigo wrote: > > On Sunday 14 December 2008, Marco Martin wrote: > > > Hi all, > > > speaking with fredrikh about speed with window masks some things have > > > emerged: returning a qbitmap is a bit wrong, since it will have to be > > > converted to a qregion each time, so.. > > > should the framesvg mask function return a qregion? this would of > > > course break the api, so quite of a problem > > > would be source compatible but not binary compatible can still be done > > > before 4.2? (talk now or be silent forever?) worth it? > > > > we could always include a second method. but yes, better to do this NOW > > to keep the API clean. please do this asap. > > > > > as for this second problem, so it should be postponed for 4.3 i think > > > (and > > > > yes =) > > You can integrate the patch I sent earlier (you wanted to add something - > some private method for masks as I recall)
if you want to commit it no problem, was just about moving the thing around, thing about that patch is that i din't understoood from the thread if it was for 4.2 or 4.2 (is a "new feature" enough, dunno :)) anyways that patch it doesn't break anything compatibility wise, so i think it can be merged in any moment Cheers, Marco Martin > Cheerio _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
