----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/308/#review293 -----------------------------------------------------------
i don't think the checkSize from prepareShowing should be removed; it's ok to add it to showEvent, though. i do wonder, however: does layout()->activate() work as well in showEvent()? it *should* have the right size there, but maybe just not the right layout ... if layout()->activate() doesn't work, then yes, please add a checkSize() call to showEvent() - Aaron On 2008-12-13 16:07:28, Loic Marteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/308/ > ----------------------------------------------------------- > > (Updated 2008-12-13 16:07:28) > > > Review request for Plasma. > > > Summary > ------- > > Hello > > I have a bug here than trigger sometimes when tootip is moved : the thumnail > is not correctly re-centered if it's have to be moved a little to the left to > be in a correct position (i talk about the position of the thumbnail, not the > tootltip). > > I have a patch for that but since i don't understand correctly why this bug > trigger sometimes and not always, im not sure it is correct to solve the bug > in this way. > > Cheers, > > Lo > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/private/tooltip.cpp > > Diff: http://reviewboard.vidsolbach.de/r/308/diff > > > Testing > ------- > > > Screenshots > ----------- > > > http://reviewboard.vidsolbach.de/r/308/s/97/ > > > Thanks, > > Loic > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
