----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/298/#review288 -----------------------------------------------------------
Ship it! cute:) - Marco On 2008-12-10 13:34:45, Aaron Seigo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/298/ > ----------------------------------------------------------- > > (Updated 2008-12-10 13:34:45) > > > Review request for Plasma. > > > Summary > ------- > > Usage of QList instead of QSet, repeated indexing using [] and repeatedly > saving invalid element values to the config seems a bit wasteful. This patch > addresses these issues; the one expensive addition to this is that there is a > List->Set conversion on first access of an invalid item in an SVG, and a > Set->List conversion for each list of invalid items on application shutdown > due to KConfig not support QSet natively (a TODO for 4.3 i guess) > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/theme.cpp > > Diff: http://reviewboard.vidsolbach.de/r/298/diff > > > Testing > ------- > > Using it right now with a full plasma session. > > > Thanks, > > Aaron > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
