On Monday 08 December 2008 02:43:44 Aaron J. Seigo wrote: > On Sunday 07 December 2008, David Baron wrote:xperimental and backports. > > > > > While the code is not voluminous, it is longer than appropriate for > > > > such a posting. If the list permits inclusions, I can do so. > > some things that pop out at me: > > * neat idea and something that i'm sure many will find useful ... Yep. I started this because I needed it--no phone on the desk by the machine and hard to handle a telephone or cell phone while playing with the computer. > > * instead of having all those different svg's, you could put all the > elements into just one svg. more efficient all around, and probably save > your applet a few lines of code. obviously not critical =) I am very new to this and the only documentation is the .h files in /usr/include/plasma. I need better documentation. Anyway, this sounds good but ... tell me how :-) > > * lots of C like code in there, such as dealing with c strings. never fun > compared to Qt ;) Yep. A lot of this was lifted from "pure" c stuff like xringd and some examples of modem program that worked. I would eventually like to get it all into Qt4. I tried replacing the ringer with QSound but this is tied to NAS, not alsa and such. > > * popupPosition is probably wrong because you are calling it before setupUi > is called and so the size of the dialog is incorrect. also, if you move the > applet the position the position will be incorrect. so i'd recommend move > the popupPosition call to ToggleGUI where you show it. (well, only when > it's about to be shown, obviously; no point in moving it when it's just > going to be hidden =) Great. Next thing to try. > > * for the crashes, try your applet in plasmoidviewer (plasmoidviewer > <pluginName>) and see if you can get a backtrace from that. note that > plasmoidviewer does store the settings, so it's a fine way to emulate "on > next login" The applet does not crash into the viewer. The excerpt cited was after an hour sitting on the screen!
Big outstanding issue is getting icons into the UI. _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
