> On 2008-11-27 15:11:10, Aaron Seigo wrote: > > a few little things, but impressive how small the patch actually ended up > > being. neat.
Done and done, i hope it's in the least painful way (yes, with multiple views with different scaling factors will always break since it ignores transforms :)) now it also disables the text from icons on the second zoom level, so it's still usable (and with a cool animation that comes for free even:) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/285/#review271 ----------------------------------------------------------- On 2008-11-28 07:14:06, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/285/ > ----------------------------------------------------------- > > (Updated 2008-11-28 07:14:06) > > > Review request for Plasma. > > > Summary > ------- > > this makes the toolbox actions to be drawn in an horizontal line and the > cashew isn't drawn, it feels reeally dirty the polling for view transform in > the paint event, but really don't know how to react differently (a zoomed > view signal could be useful maybe?, or maybe this approach is the least > damage compared to adding signals now:) > > there are still know problems/things, like: > maybe should be drawn outside the containment, but for that need to change > the containment positioning, so would rather get an initial working thing in > before :) > > on the second level of zoom the toolbox becomes bigger than the containments, > so only icons should be shown, iconwidget lacks such an option, so either > adding it now or using toolbuttons > > anything else? (yes, pretty sure it is:p) > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/applet.cpp > /trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp > /trunk/KDE/kdelibs/plasma/private/toolbox.cpp > /trunk/KDE/kdelibs/plasma/private/toolbox_p.h > > Diff: http://reviewboard.vidsolbach.de/r/285/diff > > > Testing > ------- > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
