----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/254/#review249 -----------------------------------------------------------
Ship it! nice temporary solution to the problem; i agree that we can make this better in 4.3, but for 4.2 this is a nice touch. way to go .. /trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasksmenu.cpp <http://reviewboard.vidsolbach.de/r/254/#comment202> might look better if this was drawn only to the textRect? - Aaron On 2008-11-03 08:58:33, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/254/ > ----------------------------------------------------------- > > (Updated 2008-11-03 08:58:33) > > > Review request for Plasma. > > > Summary > ------- > > this makes the taskbar group menu to draw mostly like an extender, to > implement a mockup of the new theme > it's just a subclass of the menu with custom painting, still think in the > future should be the real tasks widgets within a view, but i kinda feel it's > a 4.3 thing :) > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/CMakeLists.txt > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasksmenu.h > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasksmenu.cpp > > Diff: http://reviewboard.vidsolbach.de/r/254/diff > > > Testing > ------- > > > Screenshots > ----------- > > > http://reviewboard.vidsolbach.de/r/254/s/90/ > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
