> On 2008-10-25 06:46:58, Marco Martin wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.h, line 111 > > <http://reviewboard.vidsolbach.de/r/241/diff/2/?file=1295#file1295line111> > > > > so this is a kind of a size, not in pixels but in cells but a kind of a > > size anyways... > > sooo could it make sense to call it > > QSize gridLayoutSize()?
would make sense, yes > On 2008-10-25 06:46:58, Marco Martin wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.h, line 78 > > <http://reviewboard.vidsolbach.de/r/241/diff/2/?file=1295#file1295line78> > > > > just some whitespace left here and there i will remove them - Christian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/241/#review235 ----------------------------------------------------------- On 2008-10-25 06:04:45, Christian Mollekopf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/241/ > ----------------------------------------------------------- > > (Updated 2008-10-25 06:04:45) > > > Review request for Plasma and Aaron Seigo. > > > Summary > ------- > > Hopefully the last major overhaul of the LayoutWidget, i put the calculation > of the coumns and the rows together since they are logically tied and removed > a lot of unused or unecessary stuff. Renamed all fillRows stuff to forceRows. > Further i implemented some vertical layout stuff so it should be basically > working now. Also the automatic calculation of the columns is now implemented > though not yet perferct. > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.h > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.cpp > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasks.cpp > > Diff: http://reviewboard.vidsolbach.de/r/241/diff > > > Testing > ------- > > just basic testing. i tried it shortly. > > > Thanks, > > Christian > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
