-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/230/#review226
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp
<http://reviewboard.vidsolbach.de/r/230/#comment181>

    look at this bit of code i realized we'd run into some serious annoyances 
down the road (and remove some optimization possibilities) ...
    
    so i altered TaskManager::windowChanged to also contain the changes that 
have occurred.
    
    this way all of these properties can use the taskChanged slot (was 
taskChangedDesktop) to cooperate by setting the takeAction and remove booleans 
in that method.
    
    so this patch should be reworked with these latest changes, otherwise it 
looks good and should be committed.


- Aaron


On 2008-10-20 06:49:25, Bart Cerneels wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/230/
> -----------------------------------------------------------
> 
> (Updated 2008-10-20 06:49:25)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Add's showOnlyMinimized to the GroupManager.
> 
> 
> This addresses bug 166570.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h
>   /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/230/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bart
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to