On Tuesday 30 September 2008, Christian Mollekopf wrote: > i think the menu should not appear without a delay since this makes it > impossible to manually sort items without defining some special button > (like alt for grouping). > > I would actually prefer if you didn't commit yet marco, because i've got > some multirow support in stock. Would be great if i could commit this first > =) (i have already included your stuff anyway) it's still not committed, so if you will include this and multirow in a commit it's just fine
> > However i would suggest that we can get a normal taskmenu with rightclick > on the task in the popup menu. > > Therefore i will add a new menu to taskactions.h in the lib because this > could probably be used by every visualization with grouping support. the "fancy way" i had in mind for doing the popup was to put the tasks in the group offscreen in a vertical layout and then just show them in a Plasma::Dialog, so in this case wouldn't be needed, however i think should not be for 4.2, since the time is tight (and i would really love to have this in 4.2, yes, i want to believe:) > > Middleclick for expanding is a good idea as i think. > > So as a conclusion for the controls that i would consider usable: > > -mousepress on group pops up group popup after a little delay > > -rightclick shows the normal menu (also in the popup menu) > > -manual sorting is done without any special key agree > -manual grouping is done by pressing the alt key (how can we tell the > user?) in the config dialog wen you set manual grouping? > > -middle click expands a group or collapses parent group if executed on > grouped task agree > > > Regards, > > Christian > > > Subject: Re: Review Request: Tasks-refactor: show group in popup menu > > From: [EMAIL PROTECTED] > > To: plasma-devel@kde.org; [EMAIL PROTECTED]; [EMAIL PROTECTED] > > Date: Tue, 30 Sep 2008 16:19:16 +0000 > > > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://reviewboard.vidsolbach.de/r/204/#review210 > > ----------------------------------------------------------- > > > > Ship it! > > > > > > good idea; perhaps improvable with comment below? > > > > > > /trunk/playground/base/plasma/applets/tasks-refactor/abstracttaskitem.cpp > > <http://reviewboard.vidsolbach.de/r/204/#comment174> > > > > i wonder if middle click shouldn't expand the group as double clicking > > did, and mouse wheel scroll through the entries? > > > > > > - Aaron > > > > On 2008-09-27 07:09:22, Marco Martin wrote: > > > ----------------------------------------------------------- > > > This is an automatically generated e-mail. To reply, visit: > > > http://reviewboard.vidsolbach.de/r/204/ > > > ----------------------------------------------------------- > > > > > > (Updated 2008-09-27 07:09:22) > > > > > > > > > Review request for Plasma. > > > > > > > > > Summary > > > ------- > > > > > > shows the group components in a simple QMenu upon mouse press and > > > activate tasks also when middle button is pressed. so this restores > > > exactly the behaviour of kde3: popup with left button and cycle group > > > components with middle button. probably this should become something > > > based on Plasma::Dialog and graphicswidgets, but let's make it work > > > before maing it pretty :p the positioning is also a bit dumb, probably > > > abstracttaskitems will need something like Applet::popupPosition() > > > > > > > > > Diffs > > > ----- > > > > > > /trunk/playground/base/plasma/applets/tasks-refactor/abstracttaskitem.c > > >pp /trunk/playground/base/plasma/applets/tasks-refactor/taskgroupitem.h > > > /trunk/playground/base/plasma/applets/tasks-refactor/taskgroupitem.cpp > > > > > > Diff: http://reviewboard.vidsolbach.de/r/204/diff > > > > > > > > > Testing > > > ------- > > > > > > > > > Thanks, > > > > > > Marco > > > > _______________________________________________ > > Plasma-devel mailing list > > Plasma-devel@kde.org > > https://mail.kde.org/mailman/listinfo/plasma-devel _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
