----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/205/#review209 -----------------------------------------------------------
Ship it! looks ok, except that m_profileService (and m_service for that matter) should be deleted in the dtor (or reparented to the applet) ... this mistake keeps getting made. i'm going to adjust the API in Plasma::Service to take an optional parent parameter i think. =) /trunk/KDE/kdeplasma-addons/dataengines/twitter/timelinesource.cpp <http://reviewboard.vidsolbach.de/r/205/#comment172> should be on a line by itself /trunk/KDE/kdeplasma-addons/dataengines/twitter/twitterengine.cpp <http://reviewboard.vidsolbach.de/r/205/#comment173> should that be "Profile:"? - Aaron On 2008-09-27 13:03:21, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/205/ > ----------------------------------------------------------- > > (Updated 2008-09-27 13:03:21) > > > Review request for Plasma. > > > Summary > ------- > > This adds an option in the timelineservice to downloadan user profile. used > to retrieve the own user icon when there are no own tweets in the recent ones > don't like too much how it's done in the applet part, hmm, no idea how to > make it more clean :) > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/twitter/twitter.h > /trunk/KDE/kdeplasma-addons/applets/twitter/twitter.cpp > /trunk/KDE/kdeplasma-addons/dataengines/twitter/timelinesource.h > /trunk/KDE/kdeplasma-addons/dataengines/twitter/timelinesource.cpp > /trunk/KDE/kdeplasma-addons/dataengines/twitter/twitterengine.cpp > > Diff: http://reviewboard.vidsolbach.de/r/205/diff > > > Testing > ------- > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
