----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/190/#review199 -----------------------------------------------------------
Ship it! minor issue with memory management, but otherwise looks good ... /trunk/KDE/kdeplasma-addons/applets/twitter/twitter.cpp <http://reviewboard.vidsolbach.de/r/190/#comment165> this will leak, well, at least until the dataengine is deleted. you should hang on to the service as a member of the class, or delete it when you're done with it (e.g. after the job completes). since the twitter plasmoid supports only one account at a time, a simple class member should be enough =) m_service. - Aaron On 2008-09-13 06:46:46, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/190/ > ----------------------------------------------------------- > > (Updated 2008-09-13 06:46:46) > > > Review request for Plasma. > > > Summary > ------- > > corrects some problems in the new service/dataengine (fixes > timelinewithfriends, some xml parsing stuff and the update) > and make the applet work with the new artillery > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/twitter/twitter.h > /trunk/KDE/kdeplasma-addons/applets/twitter/twitter.cpp > /trunk/KDE/kdeplasma-addons/dataengines/twitter/timelinesource.cpp > /trunk/KDE/kdeplasma-addons/dataengines/twitter/tweet.operations > /trunk/KDE/kdeplasma-addons/dataengines/twitter/twitterengine.cpp > > Diff: http://reviewboard.vidsolbach.de/r/190/diff > > > Testing > ------- > > tried retrieve and posting > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
