----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/192/#review198 -----------------------------------------------------------
Ship it! this looks good; needs to be documented on the Plasma Theme wiki page, and i think it can be made to work with setContainsMultipleImages (see comment below) fairly easily /trunk/KDE/kdebase/workspace/libs/plasma/private/applethandle.cpp <http://reviewboard.vidsolbach.de/r/192/#comment164> probably because you need to call resize on the svg after calling setContainsMultipleImages so it is the size of a single icon (e.g. 22x22) you'll want to do this anyways so that we can support using the icons in different sizes in the future. - Aaron On 2008-09-15 12:03:54, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/192/ > ----------------------------------------------------------- > > (Updated 2008-09-15 12:03:54) > > > Review request for Plasma. > > > Summary > ------- > > this is an idea was discussed a big while ago in the mailing list > http://mail.kde.org/pipermail/plasma-devel/2008-July/000019.html > and then i forgot i actually wanted to implement the thing, my bad :P > it gives the applet handle proper control icons (idea being monocromatic, as > in mockups, btw the current graphics is just a stub) > these little icons then could be used in other contexts as well > they are now in png, because at that time we decided to use png to have less > overhead. > there should be decided sane names (btw i would keep the svgs somewhere don't > know if in the same folder or somewhere else just to "have the source") > > 3.0: one big svg > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/libs/plasma/private/applethandle.cpp > /trunk/KDE/kdebase/workspace/libs/plasma/private/applethandle_p.h > > /trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/configuration-icons.svgz > > Diff: http://reviewboard.vidsolbach.de/r/192/diff > > > Testing > ------- > > > Screenshots > ----------- > > > http://reviewboard.vidsolbach.de/r/192/s/62/ > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
