Hello ! I have let this review request as it because kolourpicker dont seems to have this problem resolved. As far as i remember there was some disagreements in both solutions (solve the problem directly in pushbuttons or not) so i dont know the best way to deal with that :o)
Cheers Lo On Fri, Sep 12, 2008 at 5:08 PM, Aaron Seigo <[EMAIL PROTECTED]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/61/#review189 > ----------------------------------------------------------- > > > any work continuing on this, or should we just dump/ignore it? > > - Aaron > > > On None, Loic Marteau wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviewboard.vidsolbach.de/r/61/ >> ----------------------------------------------------------- >> >> Review request for Plasma. >> >> >> Summary >> ------- >> >> Here is an attempt to correctly deals with size constraints in kolourpicker. >> >> The problem is with the KPushButtons inside the QProxyWidget's inherited >> Plasma::PushButton. They have a minimum size in their sizePolicy. >> So the key is here : >> m_grabButton->nativeWidget()->setSizePolicy(QSizePolicy::Expanding, >> QSizePolicy::Expanding); >> >> Perhaps we have to put this line of code directly in Plasma::PushButton to >> avoid problems with other applets ? >> >> I have put some code too to define the size constraints policy in panel mode. >> >> >> Cheers >> >> >> Diffs >> ----- >> >> /trunk/KDE/kdeplasmoids/applets/kolourpicker/kolourpicker.h >> /trunk/KDE/kdeplasmoids/applets/kolourpicker/kolourpicker.cpp >> >> Diff: http://reviewboard.vidsolbach.de/r/61/diff >> >> >> Testing >> ------- >> >> Works for me >> >> >> Thanks, >> >> Loic >> >> > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
