On Thursday 11 September 2008, Richard Dale wrote:
> Then those wouldn't have any configXml object and this part of the logic
> would never be entered. I'm afraid I still don't see what the early exit
> code is doing.

that branch is only entered if there isn't a configXml + UI file. at which 
point 
it falls back to asking the ScriptEngine to do the right thing.

what i do see in that code is that this:

? ? ? ? if (uiFile.isEmpty()) {
? ? ? ? ? ? return;
? ? ? ? }

should probably be: 

? ? ? ? if (uiFile.isEmpty()) {
 ? ? ? ? ? ? if (d->script) {
? ? ? ? ? ? ? ? d->script->showConfigurationInterface();
? ? ? ? ? ? }

? ? ? ? ? ? return;
? ? ? ? }

otherwise, i'm really not understanding the issue here. could you be more 
verbose (aka "explain it for the stupid people")? =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to