On Wednesday 10 September 2008, Aaron J. Seigo wrote: > On Tuesday 09 September 2008, Marco Martin wrote: > > On Tuesday 09 September 2008, Aaron J. Seigo wrote: > > > On Tuesday 09 September 2008, Aaron J. Seigo wrote: > > > > have popupapplet support a null icon being passed into setIcon, which > > > > will cause it to kill it's own icon. at that point, you are quite > > > > free to reimplement paintInterface or instantiate your widget. > > > > > > something like the completely untested patch that is attached =) > > > > http://reviewboard.vidsolbach.de/r/182/ > > > > on popupapplet is your patch slightly modified > > looks good; i agree on the PopupApplet::icon vs Appet::icon point as well > .. good catch! so .. new name . .hum hum hum... popupIcon? not great name. > mybe someone else has a suggestion? iconForApplet? iconForPopup?
> > there is still one issue that the popup seems to become a proxywidget > > when done in the desktop > > you mean when !d->icon.isNull()? yes, that's to be expected .. "popup" here > means "external window". or do you mean in some other case? yes, for instance when i have a clock on the desktop (so the icon is null and displaying the clock instead) i click on the clock and the popup is shown but it doesn't seem to be a window, but the Plasma::dialog containing the extender seems to be on the scene, the transparency of the border is disabled and clicking away doesn't make it disappear (and thinking about a view embedded on the same scene it displays it's a bit scary idea :)) another problem: adding a clock on the desktop when plasma is already started produces a crash, at line 389 of extenderitem.cpp widget->setParentItem(this); don't understand why just setting a parent item would crash :-/ instead if the clock is saved in plasma-appletsrc it gets created without any problems Cheers, Marco Martin _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
