On Sunday 07 September 2008, Aaron Seigo wrote: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/177/#review168 > ----------------------------------------------------------- > > Ship it! > > > cool; one question: why is the text in the Visibility option buttons > centered? =) yeah, pretty annoying, it's because i'm using KStyle to paint the label, and it behaves this way (left align when there is an icon, centered when there isn't) i could redo all the text painting in the widget itself, hmm it seems a bit overkill but yeah, doable...
Cheers, Marco Martin > - Aaron > > On 2008-09-07 08:18:54, Marco Martin wrote: > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://reviewboard.vidsolbach.de/r/177/ > > ----------------------------------------------------------- > > > > (Updated 2008-09-07 08:18:54) > > > > > > Review request for Plasma. > > > > > > Summary > > ------- > > > > uses plasma theme svgs to paint the elements in the panel controller > > looks nicer and as a bonus the code it's a bit simpler > > > > > > Diffs > > ----- > > > > /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.cpp > > /trunk/KDE/kdebase/workspace/plasma/shells/desktop/positioningruler.cpp > > /trunk/KDE/kdebase/workspace/plasma/shells/desktop/toolbutton.h > > /trunk/KDE/kdebase/workspace/plasma/shells/desktop/toolbutton.cpp > > > > Diff: http://reviewboard.vidsolbach.de/r/177/diff > > > > > > Testing > > ------- > > > > tested at different screen edges > > > > > > Screenshots > > ----------- > > > > new look > > http://reviewboard.vidsolbach.de/r/177/s/57/ > > > > > > Thanks, > > > > Marco _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
