Hi David, On Thursday 04 September 2008 22:57:48 David Edmundson wrote: > This krunner adds all the bookmarks and devices that you would expect to > find in the dolphin Places panel, or the "computer" tab in the application > launcher to the krunner list. See code attached. > > I had some pointers from Sebastian Kűgler, so I should thank him in this > email. > > It's my first time submitting anything plasma related, so I've probably > missed out some parts of your coding standard. Feel free to point out > mistakes or fix it :-)
Next round :) - The coding style does not match the kdelibs one we're using in Plasma, that would need fixing, too. http://techbase.kde.org/Policies/Kdelibs_Coding_Style - what's kdDebug? (I've never heard of this, maybe something useful to know?) kdDebug() << "loading " << action.data() << "**" << action.data().value<KUrl>().url() << endl; - those debugging lines will quickly fill up your .xsession-errors, so please remove them before you commit. - Why are you linking QTSCRIPT? - Please add a comment line to the .desktop file - Maybe we need a proper icon and not re-use the bookmarks one? All in all, it looks pretty good already ... :) -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
