----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/148/#review151 -----------------------------------------------------------
Ship it! trunk/KDE/kdebase/workspace/plasma/applets/analog-clock/clock.h <http://reviewboard.vidsolbach.de/r/148/#comment125> you can actually just remove m_showTimeString; that was originally a demo of plasma DataEngine stuff (no i'm not kidding; this was the *first* plasmoid ever) ... it's pretty useless as is, and i'd rather just see the timezone string replace it =) so just ditch the time string bit that is there now and the patch looks good =) - Aaron On 2008-08-27 01:50:16, Alessandro Diaferia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/148/ > ----------------------------------------------------------- > > (Updated 2008-08-27 01:50:16) > > > Review request for Plasma. > > > Summary > ------- > > A quick patch to allow showing of timezone.. useful when you have different > clocks with different timezones =) > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/plasma/applets/analog-clock/clock.h > trunk/KDE/kdebase/workspace/plasma/applets/analog-clock/clock.cpp > trunk/KDE/kdebase/workspace/plasma/applets/analog-clock/clockConfig.ui > > Diff: http://reviewboard.vidsolbach.de/r/148/diff > > > Testing > ------- > > > Screenshots > ----------- > > many clocks > http://reviewboard.vidsolbach.de/r/148/s/45/ > config dialog > http://reviewboard.vidsolbach.de/r/148/s/46/ > > > Thanks, > > Alessandro > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
