----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/163/#review145 -----------------------------------------------------------
trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcher.cpp <http://reviewboard.vidsolbach.de/r/163/#comment118> is this still used/necessary? trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcher.cpp <http://reviewboard.vidsolbach.de/r/163/#comment117> is this actually still used? trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcher.cpp <http://reviewboard.vidsolbach.de/r/163/#comment119> my only concern with this approach is that it breaks with the way the rest of the values are handled; it's valid (even if the m_configDialog pointer will at some points during runtime be invalid; it won't ever get accessed when it is, though). it might be nice to keep with the pattern already in this widget for consistency (connecting the widget to a slot in the class that sets a temp var ...) trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcherConfig.cpp <http://reviewboard.vidsolbach.de/r/163/#comment116> you can also just do ui.chb_autoResize->setChecked(stated); you don't actually need to use CheckState unless you want to use the tristate features. - Aaron On 2008-08-29 07:37:19, michal seben wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/163/ > ----------------------------------------------------------- > > (Updated 2008-08-29 07:37:19) > > > Review request for Plasma. > > > Summary > ------- > > I made patch which allow automaticaly resize fileWatcher plasmoid, according > to the text content, you could switch on/off auto resize in fileWatcher > config :) > > > Diffs > ----- > > trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcher.h > trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcher.cpp > trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcherConfig.h > trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcherConfig.cpp > trunk/KDE/kdeplasma-addons/applets/fileWatcher/fileWatcherConfig.ui > > Diff: http://reviewboard.vidsolbach.de/r/163/diff > > > Testing > ------- > > > Screenshots > ----------- > > Changed config > http://reviewboard.vidsolbach.de/r/163/s/54/ > > > Thanks, > > michal > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
