----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/170/ -----------------------------------------------------------
Review request for Plasma. Summary ------- draws the slider widget with plasma theme elements (already existing ones, button and frame) should work well in all the garzillion combinations of vertical/horizontal/reversed aspect of the slider because uses subcontrolrects from the qstyle only ugly thing is the population of the style option, apart from that the code is quite small tickmarks are painted with qstyle, don't look really well but would have been too much code a bit overkill... Diffs ----- /trunk/KDE/kdebase/workspace/libs/plasma/widgets/slider.h /trunk/KDE/kdebase/workspace/libs/plasma/widgets/slider.cpp Diff: http://reviewboard.vidsolbach.de/r/170/diff Testing ------- horizontal, vertical, reversed with/without tickmarks Screenshots ----------- http://reviewboard.vidsolbach.de/r/170/s/56/ Thanks, Marco _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
