----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/164/#review143 -----------------------------------------------------------
Ship it! - Aaron On 2008-08-28 04:44:50, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/164/ > ----------------------------------------------------------- > > (Updated 2008-08-28 04:44:50) > > > Review request for Plasma. > > > Summary > ------- > > This patch allows the Desktop toolbox to be positioned in the four corners or > four edges, rendering the right bits of the arc. > this now is used by the containment to render a non cutted toolbox when there > is a panel on top or on right (still broken when there is both on top and on > right but there is not much to do in this case?) > and to put the toolbox on the left when the text layout is right to left > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp > /trunk/KDE/kdebase/workspace/libs/plasma/private/desktoptoolbox.cpp > /trunk/KDE/kdebase/workspace/libs/plasma/private/paneltoolbox.cpp > /trunk/KDE/kdebase/workspace/libs/plasma/private/toolbox.cpp > /trunk/KDE/kdebase/workspace/libs/plasma/private/toolbox_p.h > > Diff: http://reviewboard.vidsolbach.de/r/164/diff > > > Testing > ------- > > tried to render the toolbox in all 8 possible ways > > > Screenshots > ----------- > > top panel > http://reviewboard.vidsolbach.de/r/164/s/49/ > RTL layout > http://reviewboard.vidsolbach.de/r/164/s/50/ > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
