----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/144/#review136 -----------------------------------------------------------
Ship it! tested it, seems pretty reliable, apart from some style issues would say that is ok /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.cpp <http://reviewboard.vidsolbach.de/r/144/#comment101> should be } else { and in the other places too yeah i know this file is not coerent anyways, but would be a good start for converting it in the usual style :) - Marco On 2008-08-24 12:28:03, Javier Goday wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/144/ > ----------------------------------------------------------- > > (Updated 2008-08-24 12:28:03) > > > Review request for Plasma. > > > Summary > ------- > > Allow taskbar applet to show vertical text when plasma form factor == > Vertical and horizontal size is not enough to display the word 'caption' > (like Marco Martin saids) > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasks.cpp > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.h > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.cpp > > Diff: http://reviewboard.vidsolbach.de/r/144/diff > > > Testing > ------- > > > Screenshots > ----------- > > vertical text with small panel > http://reviewboard.vidsolbach.de/r/144/s/41/ > normal text with big panel > http://reviewboard.vidsolbach.de/r/144/s/42/ > > > Thanks, > > Javier > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
