-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/131/#review122
-----------------------------------------------------------

Ship it!


looks good, please commit.


/trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasks.cpp
<http://reviewboard.vidsolbach.de/r/131/#comment93>

    please pay attention to whitespace; it should be "if (task->" and 
".contains(task)) {" ... 


- Aaron


On 2008-08-10 10:09:39, distortedlogic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/131/
> -----------------------------------------------------------
> 
> (Updated 2008-08-10 10:09:39)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch applies to the tasks.cpp and tasks.h files within the Tasks plasma 
> applet.
> 
> It is in response to Bug 160613.  The patch allows a windowTaskItem that 
> demands attention to override the showOnlyCurrentDesktop setting.  The user 
> can then see that an application on a different desktop requires attention, 
> click the window and be brought to the desktop.  When the window no longer 
> requires attention it is no longer shown on other desktops.  This 
> modification is relatively simple and only changes a few lines.  This is my 
> first KDE patch and I would greatly appreciate the review.  I was unsure of 
> the best way to bring forward this patch so I have submitted an attachment to 
> the bugreport and sent in a request to the panel-devel mailinglist (Message 
> is waiting on admin approval).  I do not mean to be too intrusive. 
> 
> I just recently discovered svn diff so the diff file found here is the most 
> recent and most accurate compared to those found on the bugreport and mailing 
> list. 
> 
> Thank you again. 
> 
> 
> This addresses bug 160613.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasks.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasks.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/131/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> distortedlogic
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to