----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/133/#review112 -----------------------------------------------------------
Ship it! Good catch. /trunk/KDE/kdebase/workspace/libs/taskmanager/taskrmbmenu.cpp <http://reviewboard.vidsolbach.de/r/133/#comment86> There should be an & before the word "Desktop", as in the makeDesktopsMenu(TaskPtr) method above. It might be better to follow that method in setting the title as well, by using setTitle(), rather than a constructor argument. - Alex On 2008-08-12 22:47:28, distortedlogic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/133/ > ----------------------------------------------------------- > > (Updated 2008-08-12 22:47:28) > > > Review request for Plasma. > > > Summary > ------- > > If one uses the taskrmbmenu with the TaskRMBMenu(const TaskList&, bool > showAll = true, QWidget *parent = 0) constructor, the "All to Desktop" > submenu never has its title set. This patch makes the submenu call the > constructor with its title. > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskrmbmenu.cpp > > Diff: http://reviewboard.vidsolbach.de/r/133/diff > > > Testing > ------- > > > Thanks, > > distortedlogic > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
