Your message dated Thu, 18 Jul 2019 18:35:11 +0000
with message-id <[email protected]>
and subject line Bug#931719: fixed in systemd 241-7
has caused the Debian Bug report #931719,
regarding 40-systemd: line 11: 1: unbound variable when sourcing 
/lib/lsb/init-functions with $1 unset
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
931719: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=931719
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: systemd
Version: 241-5
Severity: normal
Tags: patch

Dear Maintainer,

After upgrading to Debian 10 we noticed a slightly different behaviour
in  /lib/lsb/init-functions.d/40-systemd which caused one of our scripts
to break and which also causes some /etc/init.d files like /etc/init.d/mysql
to no longer to display their help text when calling them without a parameter.

The root cause are accesses to the $1 and $2 variables without checking
if they are defined beforehand. When running code using "set -u", this
causes the above mentioned error.

I've outlined this very simple fix which bypasses all further tests if
$1 and so on are undefined.

        $ diff -C 9 40-systemd.orig 40-systemd 
        *** 40-systemd.orig     2019-05-24 22:58:59.000000000 +0200
        --- 40-systemd  2019-07-09 16:40:39.642678140 +0200
        ***************
        *** 1,18 ****
        --- 1,21 ----
          # -*-Shell-script-*-
          # /lib/lsb/init-functions

          _use_systemctl=0
          if [ -d /run/systemd/system ]; then

              if [ -n "${__init_d_script_name:-}" ]; then # scripts run
with new init-d-script
                  executable="$__init_d_script_name"
                  argument="$1"
        +     elif [ $# -eq 0 ] ; then
        +         executable="$0"
        +         argument=""
              elif [ "${0##*/}" = "init-d-script" ] ||
                   [ "${0##*/}" = "${1##*/}" ]; then # scripts run with
old  init-d-script
                  executable="$1"
                  argument="$2"
              else # plain old scripts
                  executable="$0"
                  argument="$1"
              fi

-- Package-specific info:

-- System Information:
Debian Release: 10.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/32 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages systemd depends on:
ii  adduser          3.118
ii  libacl1          2.2.53-4
ii  libapparmor1     2.13.2-10
ii  libaudit1        1:2.8.4-3
ii  libblkid1        2.33.1-0.1
ii  libc6            2.28-10
ii  libcap2          1:2.25-2
ii  libcryptsetup12  2:2.1.0-5
ii  libgcrypt20      1.8.4-5
ii  libgnutls30      3.6.7-4
ii  libgpg-error0    1.35-1
ii  libidn11         1.33-2.2
ii  libip4tc0        1.8.2-4
ii  libkmod2         26-1
ii  liblz4-1         1.8.3-1
ii  liblzma5         5.2.4-1
ii  libmount1        2.33.1-0.1
ii  libpam0g         1.3.1-5
ii  libseccomp2      2.3.3-4
ii  libselinux1      2.8-1+b1
ii  libsystemd0      241-5
ii  mount            2.33.1-0.1
ii  util-linux       2.33.1-0.1

Versions of packages systemd recommends:
ii  dbus            1.12.16-1
ii  libpam-systemd  241-5

Versions of packages systemd suggests:
ii  policykit-1        0.105-25
pn  systemd-container  <none>

Versions of packages systemd is related to:
pn  dracut           <none>
ii  initramfs-tools  0.133
ii  udev             241-5

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: systemd
Source-Version: 241-7

We believe that the bug you reported is fixed in the latest version of
systemd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Biebl <[email protected]> (supplier of updated systemd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 18 Jul 2019 19:38:23 +0200
Source: systemd
Architecture: source
Version: 241-7
Distribution: unstable
Urgency: medium
Maintainer: Debian systemd Maintainers 
<[email protected]>
Changed-By: Michael Biebl <[email protected]>
Closes: 931636 931719 931850
Changes:
 systemd (241-7) unstable; urgency=medium
 .
   [ Michael Biebl ]
   * network: Fix failure to bring up interface with Linux kernel 5.2.
     Backport two patches from systemd master in order to fix a bug with 5.2
     kernels where the network interface fails to come up with the following
     error: "enp3s0: Could not bring up interface: Invalid argument"
     (Closes: #931636)
   * Use /usr/sbin/nologin as nologin shell.
     In Debian the nologin shell is installed in /usr/sbin, not /sbin.
     (Closes: #931850)
 .
   [ Mert Dirik ]
   * 40-systemd: Don't fail if SysV init script uses set -u and $1 is unset
     (Closes: #931719)
Checksums-Sha1:
 af33b92a00c8f710d3da169e433917a94e5447cf 4914 systemd_241-7.dsc
 fc5c0b60a2be5ad1f6fa06e4e0c5beb1bf21da1f 164076 systemd_241-7.debian.tar.xz
 3425965d15ed951670d311895eb51cfa722a3c92 9300 systemd_241-7_source.buildinfo
Checksums-Sha256:
 b82df11c2ed4fce101b3b56515ce507a733ed0f41c2560f31b917022d7292182 4914 
systemd_241-7.dsc
 7815fd139ef8b9ec1cb8e7674bb12023d816df67afa332b231c9f4c98813fdbe 164076 
systemd_241-7.debian.tar.xz
 95184be6c6550146e5337fcf37eb40b934e1e080d5a0675035fb01cc49ac943b 9300 
systemd_241-7_source.buildinfo
Files:
 d62bf3f835a0d05f910d99e6f7e96deb 4914 admin optional systemd_241-7.dsc
 f2e5ee029b03c57abccc4fa12931ce9e 164076 admin optional 
systemd_241-7.debian.tar.xz
 f4abae4fd6a290aacc23e53b99cbe4c2 9300 admin optional 
systemd_241-7_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEECbOsLssWnJBDRcxUauHfDWCPItwFAl0wt3wACgkQauHfDWCP
ItyrOw//ZBmTcqPN32YVTLiJV/G0zORJJFDizQYZOv2LuHaxbj4QAfKxZD8ZJx/h
gy0htXq/1AVxbAsZarTRA7avEM/+NWrKX6pe5jglGOEuG3ZGzSu3pvtN7dHEPKXi
Aqa9E9f6PVHP9cmM2BtWfxZpzeUaRuc5k3D0tbVBJctFT3L+JG1Kdfui0OrumVDt
Tr49fTt2bdJfYmk4gVsdSE/uHiOdpcJsUDMfnHjEHVxCs6wsIkdhEYjBj21cR7Qb
ypdvjvGLSkrCy2v8yUSlWmbTF6IGDMhxYQZ/Jp954ljRDpavH4ral+V+X9PpssBb
C68ltyUklSDm2IrfKoE6/5y6GrSOgT8yL1cFEmQr7gBWLO2BlgUzy9MprWajCjCE
oyEBb/sm2SGs+cGW1lboqJjJI0Ph6WV9VxYvDs/Oc19EVgIe/wNsylF8j4FOQ1JH
GFIe0iSiAiLvlQQPopOdFjTvaP40VAL3Tx9fDn0QZTjtxovJUsP9MX+dc6p1mvPE
mIuA4ekdcnNkEPn9lYVsJQam3WNfuQyPGGYjpcygYS77O7ySUKWkLOgblktJLcLk
ZbEqSK2Ub1KjIFhtkHPiHD4G6HhPmjoQcS2gFeJDwrAzBKg9/SwcGIonQIsrgnKt
HAj/l4JjsemZTauMv7xW4m/t5qnj5T1wzFuY/mwYW2NURJasSD4=
=u0MQ
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
Pkg-systemd-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-systemd-maintainers

Reply via email to