Package: release.debian.org
Severity: normal
X-Debbugs-Cc: ruby-mimema...@packages.debian.org
Control: affects -1 + src:ruby-mimemagic
User: release.debian....@packages.debian.org
Usertags: unblock

Please unblock package ruby-mimemagic


[ Reason ]
The package was wrongly considered as arch:any. The package installed
the gemspec file, which is important for the interpreter to find the
library in an arch- and ruby-version-specific path, but was not
dependending on librubyx.y (for a good reason, because it's pure Ruby).
Therefore the  package was not rebuilt for the transition to ruby3.3,
and the gemspec file is in a ruby3.1-specific path: so ruby3.3 in trixie
cannot find the corresponding library.


[ Impact ]
If the unblock is not granted, the package is not usable with ruby3.3.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1109024


[ Tests ]
The package has no test, but ruby-file-validators is build-depending on
that package, and the tests pass with ruby-mimemagic 0.4.3-2.
Autopackagetest tests if the gemspec file is found by the interpreter,
this new version fixes this.


[ Risks ]
No risk involved. This is exactly the same code shipped, just installed
in an arch-independent path (as it should be). The action of the
Rakefile under /ext/mimemagic that was called during build, is replaced
by a patch to create a file containing the correct path to freedesktop
shared-mime-info database.


[ Other info ]
I forgot to increase the urgency level in the changelog. But of course,
it's better if it can migrate (much) earlier. Thanks!

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing



unblock ruby-mimemagic/0.4.3-2
[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second .deb but not in first
-------------------------------------
-rw-r--r--  root/root   
/usr/share/rubygems-integration/all/gems/mimemagic-0.4.3/lib/mimemagic.rb
-rw-r--r--  root/root   
/usr/share/rubygems-integration/all/gems/mimemagic-0.4.3/lib/mimemagic/path.rb
-rw-r--r--  root/root   
/usr/share/rubygems-integration/all/gems/mimemagic-0.4.3/lib/mimemagic/tables.rb
-rw-r--r--  root/root   
/usr/share/rubygems-integration/all/gems/mimemagic-0.4.3/lib/mimemagic/version.rb
-rw-r--r--  root/root   
/usr/share/rubygems-integration/all/specifications/mimemagic-0.4.3.gemspec

Files in first .deb but not in second
-------------------------------------
-rw-r--r--  root/root   
/usr/lib/x86_64-linux-gnu/rubygems-integration/3.1.0/extensions/x86_64-linux/3.1.0/mimemagic-0.4.3/gem.build_complete
-rw-r--r--  root/root   
/usr/lib/x86_64-linux-gnu/rubygems-integration/3.1.0/extensions/x86_64-linux/3.1.0/mimemagic-0.4.3/mimemagic/path.rb
-rw-r--r--  root/root   
/usr/lib/x86_64-linux-gnu/rubygems-integration/3.1.0/gems/mimemagic-0.4.3/lib/mimemagic.rb
-rw-r--r--  root/root   
/usr/lib/x86_64-linux-gnu/rubygems-integration/3.1.0/gems/mimemagic-0.4.3/lib/mimemagic/tables.rb
-rw-r--r--  root/root   
/usr/lib/x86_64-linux-gnu/rubygems-integration/3.1.0/gems/mimemagic-0.4.3/lib/mimemagic/version.rb
-rw-r--r--  root/root   
/usr/lib/x86_64-linux-gnu/rubygems-integration/3.1.0/specifications/mimemagic-0.4.3.gemspec

Control files: lines which differ (wdiff format)
------------------------------------------------
Architecture: [-amd64-] {+all+}
Installed-Size: [-43-] {+36+}
Version: [-0.4.3-1-] {+0.4.3-2+}
diff -Nru ruby-mimemagic-0.4.3/debian/changelog 
ruby-mimemagic-0.4.3/debian/changelog
--- ruby-mimemagic-0.4.3/debian/changelog       2023-12-18 22:01:30.000000000 
+0100
+++ ruby-mimemagic-0.4.3/debian/changelog       2025-07-12 23:07:00.000000000 
+0200
@@ -1,3 +1,14 @@
+ruby-mimemagic (0.4.3-2) unstable; urgency=medium
+
+  * Make the package arch:all as it should
+    + Stop installing the files (especially gemspec) in a
+    arch/version-specific path (Closes: #1109024)
+    + Remove the (fake) binary extension mention in gemspec file
+  * Create lib/mimemagic/path.rb by hand
+  * Do not install files from ext/
+
+ -- Cédric Boutillier <bou...@debian.org>  Sat, 12 Jul 2025 23:07:00 +0200
+
 ruby-mimemagic (0.4.3-1) unstable; urgency=medium
 
   [ Debian Janitor ]
diff -Nru ruby-mimemagic-0.4.3/debian/control 
ruby-mimemagic-0.4.3/debian/control
--- ruby-mimemagic-0.4.3/debian/control 2023-12-18 22:01:30.000000000 +0100
+++ ruby-mimemagic-0.4.3/debian/control 2025-07-12 23:07:00.000000000 +0200
@@ -16,7 +16,7 @@
 Rules-Requires-Root: no
 
 Package: ruby-mimemagic
-Architecture: any
+Architecture: all
 Depends: ${misc:Depends},
          ${ruby:Depends},
          ${shlibs:Depends},
diff -Nru ruby-mimemagic-0.4.3/debian/patches/mimemagic_path.patch 
ruby-mimemagic-0.4.3/debian/patches/mimemagic_path.patch
--- ruby-mimemagic-0.4.3/debian/patches/mimemagic_path.patch    1970-01-01 
01:00:00.000000000 +0100
+++ ruby-mimemagic-0.4.3/debian/patches/mimemagic_path.patch    2025-07-12 
23:07:00.000000000 +0200
@@ -0,0 +1,14 @@
+Description: create by hand the file with path to the mime database
+  this was the responsibility of ext/mimemagic/Rakefile
+  but it is not run anymore
+Author: Cédric Boutillier
+Last-Update: 2025-07-12
+Forwarded: no
+
+--- /dev/null
++++ b/lib/mimemagic/path.rb
+@@ -0,0 +1,4 @@
++class MimeMagic
++  DATABASE_PATH="/usr/share/mime/packages/freedesktop.org.xml"
++end
++
diff -Nru ruby-mimemagic-0.4.3/debian/patches/no_ext_gemspec.patch 
ruby-mimemagic-0.4.3/debian/patches/no_ext_gemspec.patch
--- ruby-mimemagic-0.4.3/debian/patches/no_ext_gemspec.patch    1970-01-01 
01:00:00.000000000 +0100
+++ ruby-mimemagic-0.4.3/debian/patches/no_ext_gemspec.patch    2025-07-12 
23:07:00.000000000 +0200
@@ -0,0 +1,16 @@
+Description: remove the fake extension from the gemspec file
+  this tricked gem2deb into thinking it is an arch:any package
+Author: Cédric Boutillier
+Last-Update: 2025-07-12
+Forwarded: no
+
+--- a/mimemagic.gemspec
++++ b/mimemagic.gemspec
+@@ -12,7 +12,6 @@
+ 
+   s.files         = `git ls-files`.split("\n").reject { |f| 
f.match(%r{^(test|script)/}) }
+   s.require_paths = %w(lib)
+-  s.extensions = %w(ext/mimemagic/Rakefile)
+ 
+   s.summary = 'Fast mime detection by extension or content'
+   s.description = 'Fast mime detection by extension or content (Uses 
freedesktop.org.xml shared-mime-info database)'
diff -Nru ruby-mimemagic-0.4.3/debian/patches/series 
ruby-mimemagic-0.4.3/debian/patches/series
--- ruby-mimemagic-0.4.3/debian/patches/series  1970-01-01 01:00:00.000000000 
+0100
+++ ruby-mimemagic-0.4.3/debian/patches/series  2025-07-12 23:07:00.000000000 
+0200
@@ -0,0 +1,2 @@
+mimemagic_path.patch
+no_ext_gemspec.patch
diff -Nru ruby-mimemagic-0.4.3/debian/rules ruby-mimemagic-0.4.3/debian/rules
--- ruby-mimemagic-0.4.3/debian/rules   2023-12-18 22:01:30.000000000 +0100
+++ ruby-mimemagic-0.4.3/debian/rules   2025-07-12 23:07:00.000000000 +0200
@@ -2,6 +2,7 @@
 
 export GEM2DEB_TEST_RUNNER = --check-dependencies
 export DH_RUBY = --gem-install
+export DH_RUBY_GEM_INSTALL_EXCLUDE = ext/*
 
 %:
        dh $@ --buildsystem=ruby --with ruby
diff -Nru ruby-mimemagic-0.4.3/debian/salsa-ci.yml 
ruby-mimemagic-0.4.3/debian/salsa-ci.yml
--- ruby-mimemagic-0.4.3/debian/salsa-ci.yml    1970-01-01 01:00:00.000000000 
+0100
+++ ruby-mimemagic-0.4.3/debian/salsa-ci.yml    2025-07-12 23:07:00.000000000 
+0200
@@ -0,0 +1,4 @@
+---
+include:
+  - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/salsa-ci.yml
+  - 
https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/pipeline-jobs.yml

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Pkg-ruby-extras-maintainers mailing list
Pkg-ruby-extras-maintainers@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers

Reply via email to