Package: browser-request Version: 0.3.3-1 Tags: patch autopkgtest was failing on this package because it doesn't include nodejs in the test environment. After adding nodejs, it also complains about a lack of XMLHttpRequest. I've attached a patch which fixes both of these issues. Alternatively, you can see my patch on Salsa:
https://salsa.debian.org/zebmccorkle-guest/browser-request/tree/add-test-dependencies
--
Zebulon McCorkle
Email: [email protected]
IRC:
- zebmccorkle@Freenode
- zebmccorkle@OFTC
- zeb@EsperNet
- zeb@hackint
- zeb@PdgnCo
- zeb@EFNet
PGP: 803A 0F47 82AD DDEA 46BE 055F F8F9 DB8C 1A54 6398
(Zebulon McCorkle <[email protected]>)
From a0fd4f22e7ca0ccb007e619fe3b788ee59acecc7 Mon Sep 17 00:00:00 2001 From: Zebulon McCorkle <[email protected]> Date: Thu, 24 May 2018 10:24:07 -0500 Subject: [PATCH] Add nodejs and node-xmlhttprequest as test dependencies The CI builds were failing because the chroot didn't have nodejs installed, adding nodejs as a test dependency fixes this issue. Since there is one binary package for both libjs and node, I figure the libjs version shouldn't depend on nodejs. Since it's required for testing, I put the nodejs dependency in test/control. Fixing this issue brought up another: the Node environment doesn't have a global XMLHttpRequest, which is required by browser-request. To fix this, I added node-xmlhttprequest as a test dependency and assigned its XMLHttpRequest object to `global.XMLHttpRequest`, which sates browser-request. --- debian/tests/control | 2 +- debian/tests/require | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/tests/control b/debian/tests/control index 84c9455..807e53f 100644 --- a/debian/tests/control +++ b/debian/tests/control @@ -1,2 +1,2 @@ Tests: require -Depends: node-browser-request +Depends: nodejs, node-browser-request, node-xmlhttprequest diff --git a/debian/tests/require b/debian/tests/require index 540172a..deb04e0 100644 --- a/debian/tests/require +++ b/debian/tests/require @@ -1,3 +1,3 @@ #!/bin/sh set -e -node -e "require('browser-request');" +node -e "global.XMLHttpRequest = require('xmlhttprequest').XMLHttpRequest; require('browser-request');" -- 2.17.0
signature.asc
Description: PGP signature
-- Pkg-javascript-devel mailing list [email protected] https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
