On Sun, 17 Apr 2016 20:37:38 +0900 Mizuki Asakura <[email protected]> wrote:
> Hi. > > I tried to apply series of your patch to aarch64, and the result is > impressively fine. > Thank you for your effort. If you think that the Ben's patches are good, please grant your Reviewed-by: tags for them. For more details, please check the "Signing off and reviewing" section at http://www.x.org/wiki/Development/Documentation/SubmittingPatches/ But in a nutshell, it is a simplified "language" with a small "dictionary", which helps developers to clearly understand each other when talking about patches. > Please check benchmark results on aarch64 at: > > https://bugs.freedesktop.org/attachment.cgi?id=123008 (before applied) > https://bugs.freedesktop.org/attachment.cgi?id=123010 (after applied) Comparing these logs directly is a little bit difficult without further post-processing because of the measurement noise. > On 11 April 2016 at 21:26, Ben Avison <[email protected]> wrote: > > Since there are a few people around on the list at the moment who are > > familiar with NEON, I'm hoping someone will be able to review my work so it > > can make it into git. > > > > To keep the number of patches manageable, here are a group which improve > > incrementally upon existing ARMv7 routines, without adding any new ones yet. > > Most of these are reposts which have had no review of the technical content. > > The patch numbers have been reassigned within this series of 9 patches, and > > won't match the numbers used when originally posted. > > > > Ben Avison (9): > > armv7: Coalesce scalar accesses where possible > > armv7: Faster fill operations > > armv7: Use VLD-to-all-lanes > > armv7: Simplify constant load > > armv7: Use prefetch for small-width images too > > armv7: Use aligned memory writes in both copies of bilinear code > > armv7: Move common bilinear macro definitions to a new header file > > armv7: More use of fast paths with localized destination alpha > > armv7: More use of fast paths with localized source alpha > > > > pixman/Makefile.am | 3 +- > > pixman/pixman-arm-neon-asm-bilinear.S | 153 +----------------- > > pixman/pixman-arm-neon-asm-bilinear.h | 165 +++++++++++++++++++ > > pixman/pixman-arm-neon-asm.S | 280 > > +++++++-------------------------- > > pixman/pixman-arm-neon-asm.h | 20 +++ > > pixman/pixman-arm-neon.c | 21 +++ > > 6 files changed, 272 insertions(+), 370 deletions(-) > > create mode 100644 pixman/pixman-arm-neon-asm-bilinear.h > > > > -- > > 1.7.5.4 -- Best regards, Siarhei Siamashka _______________________________________________ Pixman mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/pixman
