I didn't wanted doing such a thing because : 1) rowstride will never have a value higher than 2^31 so you will definitely lose 4 octets. But okay, nobody cases about it. 2) I didn't check that bits_image is private so I wanted avoid a breakage. So, you're right. 3) It still needs lots of change because if I change bits_image.rowstride in size_t, I will have to change also lots of variable (like the uint32_t byte_stride of the function arm_simd_fill) and parameters of function (like mips_dspr2_fill). And this is just one example but I think there's plenty.
So I think that both ways need lots of work. With my solution, I just have to find every variable which have "stride" in its name and cast every multiplication. 2013/9/9 Bill Spitzak <[email protected]> > It looks like making bits->rowstride into a size_t would be a better > solution than doing this casting? > > LE GARREC Vincent wrote: > >> Dear, >> >> I tried to create a very big image (height*stride > 2^31) but it looks >> like there's some difficulties. I reported it ( >> https://bugs.freedesktop.org/**show_bug.cgi?id=69014<https://bugs.freedesktop.org/show_bug.cgi?id=69014>) >> but the solution needs to change more than just few lines. >> >> Does someone could review the patch I made for one file ( >> https://bugs.freedesktop.org/**attachment.cgi?id=85448<https://bugs.freedesktop.org/attachment.cgi?id=85448>) >> ? If it's okay, I'll make a patch for all files. >> >> And after that, I'll make another patch for cairo that have exactly the >> same problem. >> >> Regards, >> Vincent LE GARREC >> >> >> ------------------------------**------------------------------** >> ------------ >> >> ______________________________**_________________ >> Pixman mailing list >> [email protected] >> http://lists.freedesktop.org/**mailman/listinfo/pixman<http://lists.freedesktop.org/mailman/listinfo/pixman> >> >
_______________________________________________ Pixman mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pixman
