On Fri, 30 Nov 2018 at 17:44, Eric Engestrom <[email protected]> wrote:
> On Friday, 2018-11-30 16:33:23 +0000, Ross Burton wrote:
> > On ARM, musl does not define FE_* when the architecture does not have VFP 
> > (which
> > is the right interpretation).
> >
> > As these tests depend on calling fesetround(), skip the test if FE_UPWARD 
> > isn't
> > available.
> >
> > Signed-off-by: Ross Burton <[email protected]>
>
> Maybe add to the commit message when pushing:
>
>   From the fesetround(3) man page:
>   > Each of the macros FE_TONEAREST, FE_UPWARD, FE_DOWNWARD, and
>   > FE_TOWARDZERO is defined when the implementation supports getting
>   > and setting the corresponding rounding direction.
>
> Reviewed-by: Eric Engestrom <[email protected]>

I can revise the message and re-submit, but I can't push to piglit.

Ross
_______________________________________________
Piglit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to