On 08/03/18 03:43, Dave Airlie wrote: > On 7 March 2018 at 17:52, Alejandro <[email protected]> wrote: >> Typo on the commit message: "skip is no" => "skip if no" >> >> Some comments below. >> >> On 07/03/18 01:54, Dave Airlie wrote: >>> From: Dave Airlie <[email protected]> >>> >>> These tests all require varying numbers of ssbos. >>> --- >>> .../shader_storage/layout-std140-fp64-mixed-shader.c | 5 >>> +++++ >>> .../arb_gpu_shader_fp64/shader_storage/layout-std140-fp64-shader.c | 5 >>> +++++ >>> .../shader_storage/layout-std430-fp64-mixed-shader.c | 5 >>> +++++ >>> .../arb_gpu_shader_fp64/shader_storage/layout-std430-fp64-shader.c | 5 >>> +++++ >>> 4 files changed, 20 insertions(+) >>> >>> diff --git >>> a/tests/spec/arb_gpu_shader_fp64/shader_storage/layout-std140-fp64-mixed-shader.c >>> >>> b/tests/spec/arb_gpu_shader_fp64/shader_storage/layout-std140-fp64-mixed-shader.c >>> index 96add58..e649fea 100644 >>> --- >>> a/tests/spec/arb_gpu_shader_fp64/shader_storage/layout-std140-fp64-mixed-shader.c >>> +++ >>> b/tests/spec/arb_gpu_shader_fp64/shader_storage/layout-std140-fp64-mixed-shader.c >>> @@ -213,11 +213,16 @@ piglit_init(int argc, char **argv) >>> double *map_d; >>> void *data; >>> void *data_base; >>> + GLint num_vertex_ssbo; >>> >>> piglit_require_extension("GL_ARB_shader_storage_buffer_object"); >>> piglit_require_extension("GL_ARB_gpu_shader_fp64"); >>> piglit_require_GLSL_version(150); >>> >>> + glGetIntegerv(GL_MAX_VERTEX_SHADER_STORAGE_BLOCKS, &num_vertex_ssbo); >>> + if (num_vertex_ssbo < 4) >>> + piglit_report_result(PIGLIT_SKIP); >> Why the check is <4 instead of <1 as with other new checks included on >> this patch? As far as I see, the vertex shader on that test uses 1 ssbo. > Ah test had some values like SSBO_SIZE1, 2,3 I just assumed it was > using 4, I'll switch them both to 1.
Ok, thanks for the explanation. So with that changed, plus fixing the typo on the commit message: Reviewed-by: Alejandro Piñeiro <[email protected]> BR _______________________________________________ Piglit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/piglit
